Hi,
Thank you for your testing. Yes, maybe you are right. There might be a bit tricky network traffic pattern caused by the proxy server, the vaccine solution or so on.
I'm writing the auto retry hack for the tcommon-studio-se project. It's almost done. Code is below. I will go to jila later.
And I also find the timeout setting in the downloding from nexus. NexusServerUtils.getTimeout() tells me that if nothing set in the preference page, the default value is 20000 millisecs. If we have the preference page for the value, this problem will be solved - or still needs retrying.
https://github.com/Talend/tcommon-studio-se/blob/master/main/plugins/org.talend.core.runtime/src/mai...
diff --git a/main/plugins/org.talend.core.runtime/src/main/java/org/talend/core/nexus/HttpClientTransport.java b/main/plugins/org.talend.core.runtime/src/main/java/org/talend/core/nexus/HttpClientTransport.java
index 7d023dfd40..58a3298dda 100644
--- a/main/plugins/org.talend.core.runtime/src/main/java/org/talend/core/nexus/HttpClientTransport.java
+++ b/main/plugins/org.talend.core.runtime/src/main/java/org/talend/core/nexus/HttpClientTransport.java
@@ -86,6 +86,41 @@ public abstract class HttpClientTransport {
}
public void doRequest(IProgressMonitor monitor, final URI requestURI) throws Exception {
+ int retries = 5;
+ long waitMillis = 20000;
+
+ int timeout = NexusServerUtils.getTimeout();
+ boolean fTimeout = false;
+
+ for(int t = 1; t <= retries; t++){
+ try{
+ fTimeout = false;
+ doRequestOne(monitor, requestURI);
+ } catch (java.net.SocketTimeoutException e){
+ // Read timed out
+ fTimeout = true;
+ if(t == retries){
+ throw new Exception(e);
+ }
+ } catch (Exception e) {
+ // DEBUG //
+ System.err.printf("[%d] Exception occured for %s\n", t, requestURI);
+ e.printStackTrace(System.err);
+ // DEBUG //
+ throw e;
+ }
+ if(!fTimeout){
+ break;
+ }
+ // DEBUG //
+ System.err.printf("[%d] Read timeout (in %d millisecs) occured for %s\n", t, timeout, requestURI);
+ // DEBUG //
+
+ Thread.sleep(waitMillis * t);
+ }
+ }
+
+ public void doRequestOne(IProgressMonitor monitor, final URI requestURI) throws Exception {
if (monitor == null) {
monitor = new NullProgressMonitor();
}
@@ -115,6 +150,9 @@ public abstract class HttpClientTransport {
} catch (org.apache.http.conn.HttpHostConnectException e) {
// connection failure
throw e;
+ } catch (java.net.SocketTimeoutException e){
+ // Read timed out
+ throw e;
} catch (Exception e) {
throw new Exception(requestURI.toString(), e);
} finally {
@@ -147,13 +185,15 @@ public abstract class HttpClientTransport {
address.getAddress(), proxyPort, "Http Proxy", "Http proxy authentication", null);
if (proxyAuthentication != null) {
String proxyUser = proxyAuthentication.getUserName();
- String proxyPassword = "";
- char[] passwordChars = proxyAuthentication.getPassword();
- if (passwordChars != null) {
- proxyPassword = new String(passwordChars);
+ if(StringUtils.isNotBlank(proxyUser)){
+ String proxyPassword = "";
+ char[] passwordChars = proxyAuthentication.getPassword();
+ if (passwordChars != null) {
+ proxyPassword = new String(passwordChars);
+ }
+ httpClient.getCredentialsProvider().setCredentials(new AuthScope(proxyServer, proxyPort),
+ new UsernamePasswordCredentials(proxyUser, proxyPassword));
}
- httpClient.getCredentialsProvider().setCredentials(new AuthScope(proxyServer, proxyPort),
- new UsernamePasswordCredentials(proxyUser, proxyPassword));
}
HttpHost proxyHost = new HttpHost(proxyServer, proxyPort);
httpClient.getParams().setParameter(ConnRoutePNames.DEFAULT_PROXY, proxyHost);
diff --git a/main/plugins/org.talend.librariesmanager/src/main/java/org/talend/librariesmanager/nexus/utils/NexusDownloader.java b/main/plugins/org.talend.librariesmanager/src/main/java/org/talend/librariesmanager/nexus/utils/NexusDownloader.java
index 5f62a9bc6e..f190ce3c2c 100644
--- a/main/plugins/org.talend.librariesmanager/src/main/java/org/talend/librariesmanager/nexus/utils/NexusDownloader.java
+++ b/main/plugins/org.talend.librariesmanager/src/main/java/org/talend/librariesmanager/nexus/utils/NexusDownloader.java
@@ -91,6 +91,7 @@ public class NexusDownloader implements IDownloadHelper {
NullProgressMonitor monitor = new NullProgressMonitor();
ArtifactRepositoryBean nServer = getNexusServer();
+ try{
new HttpClientTransport(nServer.getRepositoryURL(), nServer.getUserName(), nServer.getPassword()) {
@Override
@@ -145,9 +146,6 @@ public class NexusDownloader implements IDownloadHelper {
if (bos != null) {
bos.close();
}
- if (tempFolder != null) {
- FilesUtils.deleteFile(tempFolder, true);
- }
}
}
@@ -155,6 +153,11 @@ public class NexusDownloader implements IDownloadHelper {
}
}.doRequest(monitor, parseMvnUrl);
+ }finally{
+ if (tempFolder != null) {
+ FilesUtils.deleteFile(tempFolder, true);
+ }
+ }
}
}
Thank you for your cooperating.
Regards,
minek
